Fix: show favicon on the Superuser's admin #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-dev
Coverage report
This PR does not seem to contain any modification to coverable code. |
lalver1
force-pushed
the
fix/favicon-superuser-admin
branch
from
03af3c4
to
3167729
Compare
|
Oh and I didn't want to forget that this PR uses the same favicon as Benefits as @indexing suggested but we could change it to this one too in the future if we decide to have a different icon. |
lalver1
force-pushed
the
fix/favicon-superuser-admin
branch
from
3167729
to
de6ca10
Compare
lalver1
force-pushed
the
fix/favicon-superuser-admin
branch
from
de6ca10
to
dda2f3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2443
This PR overrides the
admin/base_site.htmltemplate to show the favicon in the Superuser's admin page by extending an overridden template.Reviewing
Log in as a Superuser to the admin page, click around the different models and verify that the favicon appears on the pages.